Skip to content

fix: ensure spawn-helper is executable for macos prebuilds - #866

Merged
Daniel Imms (Tyriar) merged 7 commits into
microsoft:mainfrom
devm33:macos-exec
Jan 13, 2026
Merged

fix: ensure spawn-helper is executable for macos prebuilds#866
Daniel Imms (Tyriar) merged 7 commits into
microsoft:mainfrom
devm33:macos-exec

Conversation

@devm33

@devm33 Devraj Mehta (devm33) commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #850

Also includes some minor improvements to make a test and CI less flaky

@deepak1556 Robo (deepak1556) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 Robo (deepak1556) added this to the 1.2.0 milestone Jan 11, 2026
@Tyriar
Daniel Imms (Tyriar) merged commit d70a325 into microsoft:main Jan 13, 2026
8 checks passed
Chris Bartholomew (cdbartholomew) added a commit to cdbartholomew/vipershell that referenced this pull request Apr 1, 2026
node-pty@1.1.0 ships spawn-helper and pty.node without the execute bit
(mode 644), causing "posix_spawnp failed" when vipershell tries to open
a PTY for a terminal session. Add a postinstall script that fixes the
permissions after npm install, including global installs.

The upstream bug is tracked in microsoft/node-pty#850 and fixed in
microsoft/node-pty#858 and microsoft/node-pty#866, but only available
in prerelease (1.2.0-beta.x) so far.
Nicolò Boschi (nicoloboschi) pushed a commit to nicoloboschi/sheepit that referenced this pull request Apr 2, 2026
node-pty@1.1.0 ships spawn-helper and pty.node without the execute bit
(mode 644), causing "posix_spawnp failed" when vipershell tries to open
a PTY for a terminal session. Add a postinstall script that fixes the
permissions after npm install, including global installs.

The upstream bug is tracked in microsoft/node-pty#850 and fixed in
microsoft/node-pty#858 and microsoft/node-pty#866, but only available
in prerelease (1.2.0-beta.x) so far.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: spawn-helper shipped without execute bit in npm tarball causes posix_spawnp failures (pnpm)

3 participants